From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz>, Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: pg_receivewal documentation |
Date: | 2019-07-17 05:40:48 |
Message-ID: | 44e51f9f60abb872854879c91da0ed3b67a6ba95.camel@cybertec.at |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, 2019-07-17 at 10:38 +0900, Michael Paquier wrote:
> + <para>
> + Note that while WAL will be flushed with this setting,
> + <application>pg_receivewal</application> never applies it, so
> + <xref linkend="guc-synchronous-commit"/> must not be set to
> + <literal>remote_apply</literal> if <application>pg_receivewal</application>
> + is the only synchronous standby. Similarly, if
> + <application>pg_receivewal</application> is part of a quorum-based
> + set of synchronous standbys, it won't count towards the quorum if
> + <xref linkend="guc-synchronous-commit"/> is set to
> + <literal>remote_apply</literal>.
> + </para>
>
> I think we should really document the caveat with priority-based sets
> of standbys as much as quorum-based sets. For example if a user sets
> synchronous_commit = remote_apply in postgresql.conf, and then sets
> s_s_names to '2(pg_receivewal, my_connected_standby)' to get a
> priority-based set, then you have the same problem, and pg_receivewal
> is not the only synchronous standby in this configuration. The patch
> does not cover that case properly.
I understand the concern, I'm just worried that too much accuracy may
render the sentence hard to read.
How about adding "or priority-based" after "quorum-based"?
Yours,
Laurenz Albe
From | Date | Subject | |
---|---|---|---|
Next Message | Marko Tiikkaja | 2019-07-17 05:52:06 | Re: [PATCH] Implement INSERT SET syntax |
Previous Message | Dilip Kumar | 2019-07-17 05:26:30 | Re: POC: Cleaning up orphaned files using undo logs |