Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Joshua Reich <josh(at)root(dot)net>, Rocco Altier <RoccoA(at)Routescape(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: another try at keeping AIX/ppc
Date: 2006-07-27 22:13:45
Message-ID: 44C93A99.9070000@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>
>> Maybe we need to try to stress test the comparison routines a bit to
>> make sure they really are deterministic.
>>
>
> Eyeball inspection shows that cube_cmp is wrong: it's doing
> PG_RETURN_INT16 where it should say PG_RETURN_INT32.
>

ouch, good catch!

> As best I can tell, the committed expected file is actually wrong.
> I'm going to patch both cube.out and cube_1.out to match what I
> get after fixing the function, and we'll see where that takes us.
>
> I notice that cube_2.out hasn't been updated. Was that intentional?
>

Well, I was going to wait to see a buildfarm member that needed the
alternative exponent representation, and use the regression diff as a
template

cheers

andrew

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2006-07-27 22:14:56 Re: GUC with units, details
Previous Message Bruce Momjian 2006-07-27 22:02:27 Re: [HACKERS] extension for sql update