Re: Values list-of-targetlists patch for comments (was Re:

From: Joe Conway <mail(at)joeconway(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Christopher Kings-Lynne <chris(dot)kings-lynne(at)calorieking(dot)com>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Bernd Helmle <mailings(at)oopsware(dot)de>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Susanne Ebrecht <susanne(dot)ebrecht(at)credativ(dot)de>
Subject: Re: Values list-of-targetlists patch for comments (was Re:
Date: 2006-07-24 21:22:29
Message-ID: 44C53A15.9030509@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs pgsql-hackers pgsql-patches

Tom Lane wrote:
> ISTM that this should be represented using an RTE_SUBQUERY node in the
> outer query; the alias attaches to that node, not to the VALUES itself.
> So I don't think you need that alias field in the jointree entry either.
>
> If we stick with the plan of representing VALUES as if it were SELECT *
> FROM (valuesnode), then this approach would make the second query above
> have a structure like
>
> Query
> .rtable -> RTE_SUBQUERY
> .subquery -> Query
> .jointree -> Values
>
> (leaving out a ton of detail of course, but those are the key nodes).
>

OK, I'll go try to wrap my mind around that this evening and see where
it takes me.

Thanks,

Joe

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Markus Schiltknecht 2006-07-25 11:33:44 Re: Replication - super-draft
Previous Message Tom Lane 2006-07-24 17:09:29 Re: Values list-of-targetlists patch for comments (was Re: [HACKERS] 8.2 features?)

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2006-07-24 21:23:53 Re: effective_cache_size is a real?
Previous Message Peter Eisentraut 2006-07-24 21:19:43 Re: TODO: Mark change-on-restart-only values in

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2006-07-24 22:27:29 Re: The vacuum-ignore-vacuum patch
Previous Message Robert Lor 2006-07-24 21:00:46 Re: [PATCHES] Generic Monitoring Framework with DTrace patch