Re: Allow commenting of variables in postgresql.conf to -

There is second version of patch. I made following changes:

- fix problem with assertion
- use boot_val instead default_val for all configuration data types
- add GUC_JUST_RELOAD status to track what is in configuration file or not
- revert only commented out variables
- add message what is revert to boot value

Joachim, could you explain me second point? I cannot determine
described problem. By my opinion my patch does not change this behavior.

Zdenek

Joachim Wieland wrote:
> Zdenek,
>
> Three points after a quick test:
>
> - please compile with --enable-cassert, there are wrong assertions in your
> code (you might just have to move some lines, there is an Assert() and an
> assignment thereafter)
>
> - changing a PGC_POSTMASTER should show a message:
> => parameter \"%s\" cannot be changed after server start;
> configuration file change ignored
> This seems to not show up anymore with your patch.
>
> - with the same reasoning, I think it's a good idea to display a message
> about which option falls back to its default value.
>
>
> Joachim
>
>