Re: Allow commenting of variables in postgresql.conf to - try2

From: Joachim Wieland <joe(at)mcknight(dot)de>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Allow commenting of variables in postgresql.conf to - try2
Date: 2006-05-31 17:58:16
Message-ID: 20060531175816.GA4225@mcknight.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Zdenek,

On Wed, May 31, 2006 at 06:13:04PM +0200, Zdenek Kotala wrote:
> Joachim, could you explain me second point? I cannot determine
> described problem. By my opinion my patch does not change this behavior.

I guess what I saw was another phenomenon:

I do the following:

- vi postgresql.conf => "allow_system_table_mods = true"
- start postmaster
- vi postgresql.conf => "# allow_system_table_mods = true" (commented)
- killall -HUP postmaster

Then I get _no_ message. After another killall -HUP I do indeed get a
message. So I don't get it just for the first time which is strange, do you
see that as well?

However the message I get is that it got reset to its default value which is
wrong because its a PGC_POSTMASTER variable that can only be set at server
start (set_config_option() returns true in this case as well).

Consequently I expect to get it for every other signal I send (because the
old value is still active and differs from what is in the configuration
file).

Joachim

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andreas Pflug 2006-05-31 18:13:23 Re: Possible TODO item: copy to/from pipe
Previous Message Chris Browne 2006-05-31 17:51:45 Re: Possible TODO item: copy to/from pipe

Browse pgsql-patches by date

  From Date Subject
Next Message Marko Kreen 2006-05-31 18:35:23 Re: [PATCH] Magic block for modules
Previous Message Martijn van Oosterhout 2006-05-31 17:24:59 Re: [PATCH] Magic block for modules