Re: Fix for erroneous warning on Shutdown

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org, Simon Riggs <simon(at)2ndquadrant(dot)com>
Subject: Re: Fix for erroneous warning on Shutdown
Date: 2004-06-15 20:04:53
Message-ID: 4468.1087329893@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32 pgsql-patches

Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> Just to confirm that Simon is not suffering this uniquely, I saw this
> the other day on Windows, I believe - meant to report it but it got away
> from me.

Oh, I bet I know what's going on --- are you guys launching the
postmaster in a console window and then typing ^C to shut it down?
Depending on your shell that might result in SIGINT being delivered
not only to the postmaster but to all its children. Backends, if
any, will take that as a query-cancel while the bgwriter will take
it as a checkpoint request. Which could easily result in the
too-frequent-checkpoints message.

The only real fix I can see for this is to use some other signal than
SIGINT to transmit checkpoint requests to the bgwriter. Maybe we could
piggyback all bgwriter requests onto SIGUSR2, comparable to the way that
signals up to the postmaster are now handled. Not sure how important
it is though.

regards, tom lane

In response to

Responses

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Simon Riggs 2004-06-15 20:57:04 Re: Fix for erroneous warning on Shutdown
Previous Message Andrew Dunstan 2004-06-15 19:31:42 Re: Fix for erroneous warning on Shutdown

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2004-06-15 20:17:41 Re: stderr & win32 admin check
Previous Message Andrew Dunstan 2004-06-15 19:31:42 Re: Fix for erroneous warning on Shutdown