| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pg_bsd_indent compiles bytecode |
| Date: | 2020-06-30 01:38:44 |
| Message-ID: | 446077.1593481124@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> It's easy enough to fix by just adding a ifndef PROGRAM around the piece
> adding the depency to the .bc files:
> ifeq ($(with_llvm), yes)
> ifndef PROGRAM
> all: $(addsuffix .bc, $(MODULES)) $(patsubst %.o,%.bc, $(OBJS))
> endif # PROGRAM
> endif # with_llvm
> but it's not particularly pretty. But given the way pgxs.mk is
> structured, I'm not sure there's really a great answer?
Yeah. The only other plausible alternative I see is like this:
ifeq ($(with_llvm), yes)
ifdef MODULES
all: $(addsuffix .bc, $(MODULES))
endif # MODULES
ifdef MODULE_big
all: $(patsubst %.o,%.bc, $(OBJS))
endif # MODULE_big
endif # with_llvm
which might be a little nicer because it squares better with,
eg, the install/uninstall rules. But it's not much better.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2020-06-30 03:18:03 | Re: POC: postgres_fdw insert batching |
| Previous Message | Tom Lane | 2020-06-30 01:27:48 | Re: pg_bsd_indent compiles bytecode |