Re: ABI Compliance Checker GSoC Project

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David E(dot) Wheeler" <david(at)justatheory(dot)com>
Cc: Mankirat Singh <mankiratsingh1315(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Subject: Re: ABI Compliance Checker GSoC Project
Date: 2025-07-13 20:00:10
Message-ID: 445156.1752436810@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"David E. Wheeler" <david(at)justatheory(dot)com> writes:
> How bout we keep it a simple as possible to start with: make it either the last tag in the branch or else the first commit in the branch (the branch commit). Except for master, in which case perhaps since the last time a branch was created?

I do not think we either need or want ABI checking on master.
I'm not even convinced we want it on a currently-beta branch;
having to update the reference point after each ABI-breaking
commit seems like mostly make-work until we approach RC stage.
I like the idea of an in-tree file partly because the decision
about when to create it in a branch could be made dynamically.

If we do want to drive this off tags, I'd suggest a rule like
"Use the most recent tag of the form REL_m_n or REL_m_RCn;
if there is none in this branch, don't perform ABI checking".
But I still wonder how expensive it'll be to determine that.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2025-07-13 20:42:49 Re: Proposal: Role Sandboxing for Secure Impersonation
Previous Message David E. Wheeler 2025-07-13 19:47:18 Re: ABI Compliance Checker GSoC Project