| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> |
| Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] fix a performance issue with multiple logical-decoding walsenders |
| Date: | 2020-01-06 17:57:33 |
| Message-ID: | 4445.1578333453@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Pierre Ducroquet <p(dot)psql(at)pinaraf(dot)info> writes:
> Attached to this email is a patch with better comments regarding the
> XLogSendLogical change.
Hi,
This patch entirely fails to apply for me (and for the cfbot too).
It looks like (a) it's missing a final newline and (b) all the tabs
have been mangled into spaces, and not correctly mangled either.
I could probably reconstruct a workable patch if I had to, but
it seems likely that it'd be easier for you to resend it with a
little more care about attaching an unmodified attachment.
As for the question of back-patching, it seems to me that it'd
likely be reasonable to put this into v12, but probably not
further back. There will be no interest in back-patching
commit cfdf4dc4f, and it seems like the argument for this
patch is relatively weak without that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Stehule | 2020-01-06 18:08:23 | Re: proposal: minscale, rtrim, btrim functions for numeric |
| Previous Message | Vik Fearing | 2020-01-06 17:49:45 | Re: Recognizing superuser in pg_hba.conf |