Re: [PATCHES] snprintf() argument reordering not working

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, ntufar(at)gmail(dot)com, devrim(at)kivi(dot)com(dot)tr, mha(at)sollentuna(dot)net, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCHES] snprintf() argument reordering not working
Date: 2005-12-06 15:42:53
Message-ID: 4395B17D.7080009@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Dunstan wrote:

>
>
>
> I committed the pg_regress change back in Nov but didn't change
> buildfarm to use it. And now I look at it more closely I think it
> won't work. We have:
>
> / # locale
> / NOLOCALE :=
> ifdef NO_LOCALE
> NOLOCALE += --no-locale
> endif
>
> I think instead of the += line we need:
>
> override NOLOCALE := --nolocale
>
>

and if I look after I have had some coffee I will see the underscore I
missed that makes it make sense. We now return you to your regular viewing.

cheers

andrew

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Chris Browne 2005-12-06 15:43:10 Re: Replication on the backend
Previous Message Christopher Kings-Lynne 2005-12-06 15:39:44 Oddity with extract microseconds?

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-12-06 18:20:15 Re: Reduce NUMERIC size by 2 bytes, reduce max length to 508
Previous Message Andrew Dunstan 2005-12-06 15:38:11 Re: [PATCHES] snprintf() argument reordering not working