Re: Default extension for sql scripts

Dave Page wrote:
>>But I didn't plan to submit patches for actually opening a saved query
>>with a double-click before 1.4 was branched. I just wanted to make
>>pgAdmin3 announce the extension .sql, and provide an icon for it -
>>something I more or less consider to be part of "behaving like a good
>>osx citizen".
>
> Actually I'd say that's precisely what it doesn't do. By associating the
> icon, you're allowing the user to open that filetype in pgAdmin. Only it
> doesn't. If you leave it un-associated, at least the finder will ask them
> what app to open it in so they can do something useful.

Hm... you're right, I guess.

>>I belive the Info.plist changes I sent are still
>>ok for 1.4 - even if it's a bit strange that pgadmin will startup on
>>double-clicking a file, but won't actually open the query. If you
>>deem that behaviour unacceptably, then I could try to figure out
>>how to prevent it.
>
> Well for no I just rolled back the info.plist changes, and left the
makefile
> changes and the extra file in place. I guess that should do the job
for now.
If you rolled back the Info.plist changes, you should revert the
Makefile.am,
and remove the sql.icns file too - or at least revert the Makefile.am,
so that the
sql.icns file doesn't get installed anymore.

Leaving the sql.icns file there does _not_ associate it with .sql files,
if thats
what you want to accomplish by reverting the Info.plist, and leaving the
file there.
The binding of sql.icns <-> .sql extension happens in the Infoo.plist file.

Attached is a new Info.plist file that _prevents_ pgadmin3 from opening when
a user double-clicks a sql-file. It still announces the icon, and still
has it's version
set to 1.4. Would you consider using that for 1.4?

Greetings, Florian Pflug