Re: fetch_search_path() and elog.c

From: Ferruccio Zamuner <nonsolosoft(at)diff(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: fetch_search_path() and elog.c
Date: 2005-07-11 16:22:26
Message-ID: 42D29CC2.90201@diff.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:

>Ferruccio Zamuner <nonsolosoft(at)diff(dot)org> writes:
>
>
>>I need to have in the log_line_prefix the search_path where the query
>>has run.
>>So last week I've started to read elog.c and I was thinking about a
>>small patch there using a new "%S" option.
>>
>>
>
>There's no chance of that code working when not inside a transaction;
>which means that in most of the scenarios where you really want a log
>entry to be made, it will fail.
>
> regards, tom lane
>
>
Now I've found a simpler solution:

case 'S':
/* estrae il search_path */
if (namespace_search_path != NULL)
appendStringInfo(buf, "%s ", namespace_search_path);
break;

It seems to work.

But I would like to understand why previous code was wrong.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Josh Berkus 2005-07-11 16:27:19 Re: Hide source code
Previous Message Josh Berkus 2005-07-11 16:22:06 Re: Checkpoint cost, looks like it is WAL/CRC