Re: pg_createsubscriber --dry-run logging concerns

From: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
To: "Peter Eisentraut" <peter(at)eisentraut(dot)org>, "Peter Smith" <smithpb2250(at)gmail(dot)com>
Cc: "Chao Li" <li(dot)evan(dot)chao(at)gmail(dot)com>, "Euler Taveira" <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, "L(dot) pgsql-hackers" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber --dry-run logging concerns
Date: 2026-06-29 21:13:02
Message-ID: 429fc5c5-ddbe-452b-9f37-19d97044f270@app.fastmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2026-06-29, Peter Eisentraut wrote:

> I have a follow-up for this. Earlier in this thread it was asked to
> combine the dry-run info message into one string with a newline. But I
> think this doesn't really fit the message style guidelines. I suggest
> to use a primary plus detail style here too. How about the attached patch?

Yeah, that works for me. It makes me wonder what was I thinking when I requested that newline.

--
Álvaro Herrera

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Zsolt Parragi 2026-06-29 21:16:59 Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks
Previous Message Bharath Rupireddy 2026-06-29 21:13:00 Multi-insert for logical replication apply