Re: pg_createsubscriber --dry-run logging concerns

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Peter Smith <smithpb2250(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>, Euler Taveira <euler(at)eulerto(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pg_createsubscriber --dry-run logging concerns
Date: 2026-06-29 13:56:35
Message-ID: a699024f-26d0-4bbe-b5ce-0437682bbe25@eisentraut.org
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 18.11.25 22:35, Peter Smith wrote:
> On Wed, Nov 19, 2025 at 2:39 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>>
>> On 2025-Nov-12, Peter Smith wrote:
>>
>>> It is tempting to implement a "--silent" mode, but if I did that, I
>>> would then feel obliged to document and test it. I don't want to go
>>> further down this rabbit hole for what was originally supposed to be
>>> trivial logging.
>>
>> Yeah, I understand.
>>
>>> So, I am calling it quits for this 0001 patch.
>>>
>>> Perhaps it's still of some use to push changes for everything except
>>> the pg_resetwal? Or if you prefer to just abandon the whole patch,
>>> that is OK too. Thanks for trying.
>>
>> Got it. I pushed it for the other programs and marked the CF entry as
>> committed -- thanks for the patches and the discussion.
>
> Thanks for pushing!

I have a follow-up for this. Earlier in this thread it was asked to
combine the dry-run info message into one string with a newline. But I
think this doesn't really fit the message style guidelines. I suggest
to use a primary plus detail style here too. How about the attached patch?

Attachment Content-Type Size
0001-Split-dry-run-messages-into-primary-and-detail.patch text/plain 3.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Christoph Berg 2026-06-29 14:16:04 Re: [PATCH] Document wal_compression=on
Previous Message jian he 2026-06-29 13:54:56 Re: coerce_type discard unnecessary CollateExprs