| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | Richard Guo <guofenglinux(at)gmail(dot)com>, James Coleman <jtc331(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: sqlsmith crash incremental sort |
| Date: | 2020-04-23 14:56:42 |
| Message-ID: | 4238.1587653802@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> On Thu, Apr 23, 2020 at 03:28:21PM +0800, Richard Guo wrote:
>> A minor comment is that I don't think we need to strip relabel
>> explicitly before calling pull_varnos(), because this function would
>> recurse into T_RelabelType nodes.
> Hmmm, yeah. I think you're right that's unnecessary. I misread the
> walker function, I think.
+1, might as well simplify the code.
>> Also do we need to call bms_free(varnos) for each pathkey here to avoid
>> waste of memory?
> I don't think so. It wouldn't hurt, but we don't do that for other
> pull_vernos calls either AFAICS.
Yeah, the planner is generally pretty profligate of memory, and these
bitmaps aren't likely to be huge anyway.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2020-04-23 15:39:11 | Re: More efficient RI checks - take 2 |
| Previous Message | Tomas Vondra | 2020-04-23 14:55:51 | Re: Binary search in ScalarArrayOpExpr for OR'd constant arrays |