| From: | Andrey Borodin <x4mmm(at)yandex-team(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, David Christensen <david(dot)christensen(at)crunchydata(dot)com>, Ian Lawrence Barwick <barwick(at)gmail(dot)com>, Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH] Teach pg_waldump to extract FPIs from the WAL |
| Date: | 2026-01-13 08:20:23 |
| Message-ID: | 4226AED7-E38F-419B-AAED-9BC853FB55DE@yandex-team.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 27 Dec 2022, at 04:32, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> Sure. Done that too, and applied the change after a last lookup.
Sorry for bumping old thread. I'm toying with enabling wal_consistency_checking here and there.
I've found the way with PG_TEST_EXTRA=wal_consistency_checking, but also I was thinking what if we enable it everywhere...
Overall it seems difficult to just add PGOPTION="-c wal_consistency_checking=all" on a buildfarm animal.
This happens mostly because frontends cannot connect with unprivileged role with wal_consistency_checking in PGOPTION.
But this particular test of pg_waldump fails due to LSN comparison logic.
The test expects LSN in saved file to be strictly less than LSN in file name.
This is violated when wal_consistency_checking is enabled: LSNs are equal.
Maybe we can relax the test here?
Thanks!
Best regards, Andrey Borodin.
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-pg_waldump-tests-less-strict-LSN-comparison-for-bloc.patch | application/octet-stream | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2026-01-13 08:22:01 | Re: [PATCH] Add sampling statistics to autoanalyze log output |
| Previous Message | zengman | 2026-01-13 08:05:57 | Re: [[BUG] pg_stat_statements crashes with var and non-var expressions in IN clause |