| From: | Dilip kumar <dilip(dot)kumar(at)huawei(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, Noah Misch <noah(at)leadboat(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_basebackup vs. Windows and tablespaces |
| Date: | 2014-09-11 03:40:31 |
| Message-ID: | 4205E661176A124FAF891E0A6BA91352663515BC@szxeml509-mbs.china.huawei.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20 August 2014 19:49, Amit Kapila Wrote
> There are some comments I would like to share with you
>
>
>
> 1. Rebase the patch to current GIT head.
>Done.
>> + initStringInfo(&symlinkfbuf);
>>
>> I think declaration and initialization of symlinkfbuf string can be moved under #ifdef WIN32 compile time macro,
>>
>> for other platform it’s simply allocated and freed which can be avoided.
>Agreed, I have changed the patch as per your suggestion.
I have done the testing and behavior is as per expectation,
Do we need to do some document change? I mean is this limitation on windows is mentioned anywhere ?
If no change then i will move the patch to “Ready For Committer”.
Thanks & Regards,
Dilip
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Craig Ringer | 2014-09-11 04:20:37 | Re: Aussie timezone database changes incoming |
| Previous Message | Michael Paquier | 2014-09-11 03:40:08 | Re: Support for N synchronous standby servers |