Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Kirill Reshke <reshkekirill(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
Date: 2026-05-12 02:31:05
Message-ID: 41CE1664-61E0-4857-A27A-924A6AD42B11@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On May 12, 2026, at 00:21, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
> On 2026-May-11, Chao Li wrote:
>
>>> On May 10, 2026, at 06:38, Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>
>>> I think it would be a good idea to make identity_key_equal() not deform
>>> all attributes, but instead only up to the last one it needs for the key
>>> comparisons.
>>
>> That’s true. Please see v3.
>
> Thanks. I did one further small change, namely to determine these last
> attnums just once per run rather than once per tuple. Pushed now.
>
> Thanks for testing!
>
> --
> Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/

Hi Álvaro, thank you so much for tuning the code and pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Treat 2026-05-12 02:34:47 Re: First draft of PG 19 release notes
Previous Message Hayato Kuroda (Fujitsu) 2026-05-12 02:25:47 RE: Adding REPACK [concurrently]