Re: fix compile warning for pg_backup_tar.c

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix compile warning for pg_backup_tar.c
Date: 2004-11-08 19:23:53
Message-ID: 418FC7C9.8070105@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Peter Eisentraut wrote:

>Andrew Dunstan wrote:
>
>
>>ISTM that what is happening here is that the compiler is smart enough
>>to know that what is in MAX_TAR_MEMBER_FILELEN can't be exceeded by
>>any possible value of type off_t.
>>
>>
>
>Yeah, I think off_t is only 32 bits there. Then using INT64_IS_BUSTED
>as conditional is really misleading.\
>
>

What would you like me to use? Or maybe we should just do this in all
cases instead of using an ifdef?

cheers

andrew

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Neil Conway 2004-11-09 05:32:12 GiST: perf. work, index tuple killing
Previous Message Peter Eisentraut 2004-11-08 18:48:35 Re: fix compile warning for pg_backup_tar.c