Re: fix compile warning for pg_backup_tar.c

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: fix compile warning for pg_backup_tar.c
Date: 2004-11-08 18:48:35
Message-ID: 200411081948.35112.peter_e@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Andrew Dunstan wrote:
> ISTM that what is happening here is that the compiler is smart enough
> to know that what is in MAX_TAR_MEMBER_FILELEN can't be exceeded by
> any possible value of type off_t.

Yeah, I think off_t is only 32 bits there. Then using INT64_IS_BUSTED
as conditional is really misleading.

--
Peter Eisentraut
http://developer.postgresql.org/~petere/

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-11-08 19:23:53 Re: fix compile warning for pg_backup_tar.c
Previous Message Andrew Dunstan 2004-11-08 18:24:10 Re: fix compile warning for pg_backup_tar.c