| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Richard Guo <guofenglinux(at)gmail(dot)com> |
| Subject: | Re: [PATCH] SAOP nullability analysis below NOT/BooleanTest |
| Date: | 2026-07-28 17:03:15 |
| Message-ID: | 4171084.1785258195@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> writes:
> While looking at the recent work around converting NOT IN sublinks to
> anti-joins, I came across what looks like a possible issue in the
> ScalarArrayOpExpr handling in find_nonnullable_rels() and
> find_nonnullable_vars().
This is an odd one. Why did I add the falseOK argument to
is_strict_saop and then not use it in all three callers? Sadly, I don't
recall what I was thinking twenty years ago. But you're clearly right
that all of them should be accounting for this effect.
I'm inclined to merge this patch with your other SAOP correction,
since they're so closely related.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ayush Tiwari | 2026-07-28 17:06:33 | Re: [PATCH] SAOP nullability analysis below NOT/BooleanTest |
| Previous Message | Tom Lane | 2026-07-28 16:46:43 | Re: [PATCH] Possible wrong result from inlining a STRICT SQL function |