Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com> writes:
> It looks like contain_nonstrict_functions() now relies on
> check_functions_in_node() for ScalarArrayOpExpr. That verifies that the
> operator function is strict, but it does not account for whether the
> array can be empty. Before 2f153ddfdd3, this code used
> is_strict_saop() with falseOK = false.
Ugh, yes, clearly brain fade on my part. I think your proposed
test cases are quite excessive, but the code patch seems sound.
Will get it committed.
regards, tom lane