| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | Mark Rofail <markm(dot)rofail(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
| Cc: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, David Steele <david(at)pgmasters(dot)net>, Erik Rijkers <er(at)xs4all(dot)nl>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at> |
| Subject: | Re: [HACKERS] GSoC 2017: Foreign Key Arrays |
| Date: | 2018-01-30 23:52:50 |
| Message-ID: | 4157a5f1-d2ab-02bf-f497-5753190aa75e@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/21/2018 10:36 PM, Mark Rofail wrote:
> == The @>> operator
>
> A previous version of your patch added the "anyelement <<@ anyarray"
> operator to avoid having to build arrays, but that part was reverted
> due to a bug.
>
> I am not expert on the gin code, but as far as I can tell it would
> be relatively simple to fix that bug. Just allocate an array of
> Datums of length one where you put the element you are searching for
> (or maybe a copy of it).
>
> The @>> is now restored and functioning correctly, all issues with
> contrib libraries has been resolved
Hi,
I looked some at your anyarray @>> anyelement code and sadly it does not
look like the index code could work. The issue I see is that
ginqueryarrayextract() needs to make a copy of the search key but to do
so it needs to know the type of anyelement (to know if it needs to
detoast, etc). But there is as far as I can tell no way to check the
type of anyelement in this context.
Am I missing something?
Andreas
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ivan Novick | 2018-01-30 23:57:26 | Re: Regarding drop index |
| Previous Message | Jason Petersen | 2018-01-30 23:25:19 | Re: JIT compiling with LLVM v9.0 |