Re: "unix_socket_directories" should be GUC_LIST_INPUT?

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Ian Lawrence Barwick <barwick(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: "unix_socket_directories" should be GUC_LIST_INPUT?
Date: 2020-10-27 10:42:28
Message-ID: 414434e5-a16d-6c82-131a-d155f400c2ff@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-10-23 10:02, Michael Paquier wrote:
>> So maybe we could get away with just changing it. It'd be good to
>> verify though that this doesn't break existing string values for
>> the variable, assuming they contain no unlikely characters that'd
>> need quoting.
>
> Yeah, that's the kind of things I wanted to check anyway before
> considering doing the switch.

If we're going to change it I think we need an updated patch that covers
pg_dump. (Even if we argue that pg_dump would not normally dump this
variable, keeping it up to date with respect to GUC_LIST_QUOTE seems
proper.)

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-10-27 10:46:43 Re: deferred primary key and logical replication
Previous Message Peter Eisentraut 2020-10-27 10:35:25 Re: Prevent printing "next step instructions" in initdb and pg_upgrade