| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] compile warnings |
| Date: | 2004-08-04 22:45:19 |
| Message-ID: | 411166FF.9050404@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Joe Conway wrote:
> Tom Lane wrote:
>> Joe Conway <mail(at)joeconway(dot)com> writes:
>>> In addition to the ecpg warnings mentioned by Tom, I'm also seeing
>>> compile warnings wrt plpython:
>>
>> This is surely not a "must fix tomorrow" issue, but please look into it
>> when you get back from your road trip.
>
> I find that simply putting
> #include <Python.h>
> prior to
> #include "postgres.h"
> in plpython.c eliminates the warnings, and compiles fine, but it isn't
> clear to me that it is safe. Thoughts?
If there are no objections, I plan to commit the attached in a few hours.
Thanks,
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| plpython-fix.patch | text/x-patch | 709 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Oliver Jowett | 2004-08-04 22:49:07 | Re: [HACKERS] postgres and Jdbc 2.0 |
| Previous Message | Scott Marlowe | 2004-08-04 22:41:10 | Re: enforcing a join type |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Kings-Lynne | 2004-08-05 01:23:08 | Re: More fixes for pg_dump |
| Previous Message | Andreas Pflug | 2004-08-04 21:02:35 | logger subprocess including win32 |