| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Noah Misch <noah(at)leadboat(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |
| Date: | 2019-02-20 10:22:23 |
| Message-ID: | 40c5c12f-adad-fc86-7d43-ff7c535356ed@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-02-15 16:05, Christoph Berg wrote:
> Re: Andrew Gierth 2019-02-15 <874l95m8w7(dot)fsf(at)news-spur(dot)riddles(dot)org(dot)uk>
>> Also while we're tweaking regression test output, would it be possible
>> to have some indicator of whether a test passed because a variant file
>> in the resultmap was ignored in favor of the standard result?
>>
>> The current system of silently ignoring the resultmap means that nobody
>> ever notices when resultmap entries become obsolete....
>
> By the same argument, it should always print which variant file was
> used so determining which _N.out files are still in use is possible.
I would rather not overload the test output even more. A test passes or
it doesn't. If we need to collect additional information, let's think
about ways to do that separately.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matsumura, Ryo | 2019-02-20 10:40:26 | RE: SQL statement PREPARE does not work in ECPG |
| Previous Message | Peter Eisentraut | 2019-02-20 10:20:50 | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |