Re: thread safety tests

From: Jan Wieck <JanWieck(at)Yahoo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: thread safety tests
Date: 2004-06-10 06:57:06
Message-ID: 40C80642.3070307@Yahoo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 6/10/2004 2:11 AM, Tom Lane wrote:

> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> Are people OK with requiring PGUSER, $USER, $LOGNAME, or the username to
>> be supplied by the connection string in libpq on platforms that want
>> threads and don't have getpwuid_r() (Solaris, FreeBSD, etc.)?
>
> AFAICS that was not what Jan was suggesting at all. I don't like it
> either --- changing the user-visible behavior based on whether we think
> the platform is thread-safe or not is horrid.
>
> What I understood Jan to be saying is that we should be willing to build
> the most thread-safe approximation we can when --enable-thread-safety
> is requested. Don't bomb out if you don't have getpwuid_r, just give
> a warning and then use getpwuid.

Make it so that --enable-thread-safety bombs out, but make another
--enable-thread-safey-anyway work the way Tom descibed it.

Jan

--
#======================================================================#
# It's easier to get forgiveness for being wrong than for being right. #
# Let's break this rule - forgive me. #
#================================================== JanWieck(at)Yahoo(dot)com #

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Greg Stark 2004-06-10 07:32:11 Re: I/O support for composite types
Previous Message Honza Pazdziora 2004-06-10 06:42:57 Re: Improving postgresql.conf