Re: thread safety tests

Jan Wieck wrote:
> On 6/10/2004 2:11 AM, Tom Lane wrote:
>
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> >> Are people OK with requiring PGUSER, $USER, $LOGNAME, or the username to
> >> be supplied by the connection string in libpq on platforms that want
> >> threads and don't have getpwuid_r() (Solaris, FreeBSD, etc.)?
> >
> > AFAICS that was not what Jan was suggesting at all. I don't like it
> > either --- changing the user-visible behavior based on whether we think
> > the platform is thread-safe or not is horrid.
> >
> > What I understood Jan to be saying is that we should be willing to build
> > the most thread-safe approximation we can when --enable-thread-safety
> > is requested. Don't bomb out if you don't have getpwuid_r, just give
> > a warning and then use getpwuid.
>
> Make it so that --enable-thread-safety bombs out, but make another
> --enable-thread-safey-anyway work the way Tom descibed it.

Sure, we can do that by just not running the thread_test program. In
fact a cross-compile already skips running the test.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073