| From: | Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PG Patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: Bug in CVS pg_dump against 7.0.x |
| Date: | 2004-05-19 03:50:10 |
| Message-ID: | 40AAD972.1080701@familyhealth.com.au |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
>>It's not a problem, since that code path is only ever executed when
>>dumping a 7.0 backend. It's in the MyFormatType function in pg_dump.c
>>that is used whenever the backend doesn't have its own format_type function.
>
> Right. The patch looked dangerous to me too, until I understood the
> context. As-is, I think it's fine -- indeed, I think we ought to
> backpatch it into 7.4 branch too.
Strangely enough, the 7.0.x pg_dump.c does just dump arrays as bpchar_
type, but the 7.0.x psql utility displays them as character varying[]
Chris
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2004-05-19 04:22:10 | Fix for Win32 linking |
| Previous Message | Tom Lane | 2004-05-19 03:47:16 | Re: PITR Phase 1 - partial backport to 7.3.4, 7.3.5 |