Re: Bug in CVS pg_dump against 7.0.x

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PG Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Bug in CVS pg_dump against 7.0.x
Date: 2004-05-19 03:36:14
Message-ID: 11336.1084937774@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
>> Do we know that is always true? What is the issue that 7.0 needs this
>> and newer released don't, and how are we sure this will not break some
>> strange cases in post-7.0 releases?

> It's not a problem, since that code path is only ever executed when
> dumping a 7.0 backend. It's in the MyFormatType function in pg_dump.c
> that is used whenever the backend doesn't have its own format_type function.

Right. The patch looked dangerous to me too, until I understood the
context. As-is, I think it's fine -- indeed, I think we ought to
backpatch it into 7.4 branch too.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-19 03:41:04 Re: PgSQL 7.4.2 - NaN on Tru64 UNIX
Previous Message Bruce Momjian 2004-05-19 01:05:25 Re: pgsql-server/src backend/main/main.c backend/p ...