From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | remove log_timestamp, log_pid and log_source_port GUC vars |
Date: | 2004-03-10 17:49:10 |
Message-ID: | 404F5516.7010906@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
>Tom Lane wrote:
>
>
>>Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au> writes:
>>
>>
>>>>Please don't. Declare them obsolete for 7.5 and remove them in a later
>>>>release.
>>>>
>>>>
>>>Nah, just remove them. We've removed, added and changed so many config
>>>options and no-one's ever complained...
>>>
>>>
>>I agree with Chris; this would be taking compatibility concerns a bit
>>far. None of these variables are likely to be touched except through
>>postgresql.conf (I don't think we even allow them to be SET interactively).
>>And you can never simply take your old .conf file and plop it down into
>>a new release.
>>
>>
>
>And the other reason to remove them is that if you don't, you will get
>all sorts of confusion about people asking, "Which one should I use for
>pid logging? Looks like both work."
>
>
>
OK, Here's the patch. Also makes some minor improvements in the docco
for log_line_prefix.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
log.patch | text/plain | 14.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Ramanujam H S Iyengar | 2004-03-10 17:58:51 | How to get RelationName ?? |
Previous Message | Zeugswetter Andreas SB SD | 2004-03-10 17:37:41 | Re: PITR Functional Design v2 for 7.5 |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2004-03-10 19:16:12 | Re: PSQLRC environment variable. |
Previous Message | Bruce Momjian | 2004-03-10 16:57:52 | Re: [PATCHES] log_line_info |