| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl |
| Date: | 2017-12-24 17:25:48 |
| Message-ID: | 402f6839-5c8b-773a-f443-0d96298a4fa7@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/21/17 08:13, Andrew Dunstan wrote:
> Looks reasonable. Regarding the change to TestLib.pm, we should make
> sure that the tests have unique names. There is a small amount of
> duplication currently:
>
> ./src/bin/pg_dump/t/001_basic.pl
> ./src/bin/pg_rewind/t/001_basic.pl
> ./src/test/modules/commit_ts/t/001_base.pl
> ./src/test/modules/test_pg_dump/t/001_base.pl
But that's one of the reasons one has directories, so you don't need to
have globally unique names. I don't actually see why the change in
TestLib.pm is necessary or how it relates to this thread.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-12-24 17:26:53 | Re: Reproducible builds: genbki.pl and Gen_fmgrtab.pl |
| Previous Message | Tomas Vondra | 2017-12-24 13:43:49 | Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions |