Re: Reproducible builds: and

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Reproducible builds: and
Date: 2017-12-27 23:20:49
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 12/21/17 08:13, Andrew Dunstan wrote:
>> Looks reasonable. Regarding the change to, we should make
>> sure that the tests have unique names. There is a small amount of
>> duplication currently:
>> ./src/bin/pg_dump/t/
>> ./src/bin/pg_rewind/t/
>> ./src/test/modules/commit_ts/t/
>> ./src/test/modules/test_pg_dump/t/

> But that's one of the reasons one has directories, so you don't need to
> have globally unique names.

I agree that it's not obvious that we need to rename these scripts.
In the current setup for running regression tests, the associated
postmaster logs would go into different subdirectories, so the conflict
in "application" names appearing in log entries doesn't seem like it
would lead to real confusion.

> I don't actually see why the change in
> is necessary or how it relates to this thread.

Basically, as the code stood:


running any TAP test in a VPATH build would result in PGAPPNAME becoming a
full path, resulting in different log entries than you get in a non-VPATH
build. That seemed undesirable to me, so I added basename() to eliminate
the difference in behavior.

There's some room to argue that given that we have duplicate script names,
a (partial) path would be a good thing. But if you believe that, then we
should attempt to make that happen the same way with or without VPATH.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tatsuo Ishii 2017-12-28 00:29:11 Re: [HACKERS] [PATCH] Lockable views
Previous Message Alvaro Herrera 2017-12-27 22:50:31 Re: Unique indexes & constraints on partitioned tables