Re: dblink - custom datatypes NOW work :)

From: Joe Conway <mail(at)joeconway(dot)com>
To: Mark Gibson <gibsonm(at)cromwell(dot)co(dot)uk>
Cc: "Hackers (PostgreSQL)" <pgsql-hackers(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: dblink - custom datatypes NOW work :)
Date: 2004-02-13 17:30:38
Message-ID: 402D09BE.2030907@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-general pgsql-hackers pgsql-patches

Mark Gibson wrote:
> I've found the problem, although I'm still a bit confused by it.

I hate to do this to you now, but after some thought I think I have a
better approach -- I'd be interested in opinions on that assessment.

The attached eliminates pgresultGetTupleDesc() entirely and instead
depends on the TupleDesc passed as rsinfo->expectedDesc from the
executor. What this means is that the string representation of the
remote value (from the "out" function on the remote side, as provided by
libpq) will get fed into the "in" function corresponding to the local
type you assign in your SQL statement. Assuming the types on the two
sides are the same (or at least compatible), it should work well.

Please give this a try and let me know what you think.

Joe

Attachment Content-Type Size
dblink-2004.02.14.1.patch text/plain 4.4 KB

In response to

Responses

Browse pgsql-general by date

  From Date Subject
Next Message Andrew Sullivan 2004-02-13 17:47:17 Re: Quad Xeon vs. Dual Itanium
Previous Message Campano, Troy 2004-02-13 17:26:07 timestamp/date comparison

Browse pgsql-hackers by date

  From Date Subject
Next Message Joseph Tate 2004-02-13 20:49:55 pg_restore problems and suggested resolution
Previous Message m.jjoe 2004-02-13 17:26:06 Participate to translation

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-02-13 21:43:42 Re: TODO : Multiple inserts in a single statement
Previous Message Mark Cave-Ayland 2004-02-13 16:47:31 Re: ANALYZE patch for review