Re: Typos in the code and README

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Lakhin <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Subject: Re: Typos in the code and README
Date: 2026-01-05 21:50:59
Message-ID: 3ichbga56hy2y4v62slycuyt7z34gpfg64sc3z2t4ki7cylij2@mfeq4pfc5yxl
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2026-01-05 16:43:02 -0500, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > Your recent commit unfortunately doesn't build with meson, due to headers now
> > not just residing in src/include/snowball/ but also
> > src/include/snowball/libstemmer/.
>
> Yeah --- but that was true before too. I don't quite see how
> it built under meson before.

Previously the only thing including snowball/libstemmer/*h files was
src/backend/snowball/dict_snowball.c, which included them relative to
src/includ. But now they are also included from
src/backend/snowball/libstemmer/stem_*.c, just as
> #include "stem_*.h"
thereby requiring include/snowball/libstemmer to be an include path.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2026-01-05 21:53:50 Re: Disallow concurrent ALTER DOMAIN and DROP DOMAIN
Previous Message Tom Lane 2026-01-05 21:43:02 Re: Typos in the code and README