| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Alexander Lakhin <exclusion(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Subject: | Re: Typos in the code and README |
| Date: | 2026-01-05 21:55:00 |
| Message-ID: | 1448466.1767650100@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2026-01-05 16:43:02 -0500, Tom Lane wrote:
>> Yeah --- but that was true before too. I don't quite see how
>> it built under meson before.
> Previously the only thing including snowball/libstemmer/*h files was
> src/backend/snowball/dict_snowball.c, which included them relative to
> src/includ. But now they are also included from
> src/backend/snowball/libstemmer/stem_*.c,
Oh, you're right. So it worked without any Makefile changes because
the Makefile already had
override CPPFLAGS := -I$(top_srcdir)/src/include/snowball \
-I$(top_srcdir)/src/include/snowball/libstemmer $(CPPFLAGS)
but meson.build had failed to duplicate that.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-01-05 21:55:41 | Re: Decouple C++ support in Meson's PGXS from LLVM enablement |
| Previous Message | Andres Freund | 2026-01-05 21:53:50 | Re: Disallow concurrent ALTER DOMAIN and DROP DOMAIN |