| From: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>, Ildus Kurbangaliev <i(dot)kurbangaliev(at)postgrespro(dot)ru>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Bug in ExecModifyTable function and trigger issues for foreign tables |
| Date: | 2017-07-21 10:16:13 |
| Message-ID: | 3e9ff40d-d00f-3363-dcee-97ce023c7884@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2017/07/20 11:21, Etsuro Fujita wrote:
> On 2017/07/19 23:36, Tom Lane wrote:
>> Please put the responsibility of doing const-expression simplification
>> in these cases somewhere closer to where the problem is being created.
>
> It would be reasonable that it's the FDW's responsibility to do that
> const-simplification if necessary?
There seems to be no objections, so I removed the const-expression
simplification from the patch and I added the note to the docs for
AddForeignUpdateTargets.
Attached is an updated version of the patch.
Best regards,
Etsuro Fujita
| Attachment | Content-Type | Size |
|---|---|---|
| fix-rewrite-tlist-v3.patch | text/plain | 23.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2017-07-21 10:21:42 | Re: Mishandling of WCO constraints in direct foreign table modification |
| Previous Message | Alik Khilazhev | 2017-07-21 08:43:31 | Re: [WIP] Zipfian distribution in pgbench |