Re: Mishandling of WCO constraints in direct foreign table modification

From: Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
To: Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: robertmhaas(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Mishandling of WCO constraints in direct foreign table modification
Date: 2017-07-21 10:21:42
Message-ID: a4baaf5d-af3b-0cb4-d1dd-093fdc09d453@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017/07/21 17:18, Kyotaro HORIGUCHI wrote:
> At Fri, 21 Jul 2017 12:00:03 +0900, Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> wrote in <15aa9936-9bd8-c9e3-7ca1-3948610734b4(at)lab(dot)ntt(dot)co(dot)jp>
>> Attached is the second version which updated docs in postgres-fdw.sgml
>> as well.
>
> ! no local joins for the query, no row-level local <literal>BEFORE</> or
> ! <literal>AFTER</> triggers on the target table, and no
> ! <literal>CHECK OPTION</> constraints from parent views.
> ! In <command>UPDATE</>,
>
> Might be a silly question, is CHECK OPTION a "constraint"?

I mean constraints derived from WITH CHECK OPTIONs specified for parent
views. We use the words "WITH CHECK OPTION constraints" in comments in
nodeModifyTable.c, so the expression "CHECK OPTION constrains" doesn't
sound not that bad to me. (I used "CHECK OPTION", not "WITH CHECK
OPTION", because we use "CHECK OPTION" a lot more in the documentation
than "WITH CHECK OPTION".)

Best regards,
Etsuro Fujita

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Sokolov Yura 2017-07-21 10:49:40 Re: Small improvement to compactify_tuples
Previous Message Etsuro Fujita 2017-07-21 10:16:13 Re: Bug in ExecModifyTable function and trigger issues for foreign tables