Re: plpgsql - additional extra checks

From: David Steele <david(at)pgmasters(dot)net>
To: Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: plpgsql - additional extra checks
Date: 2017-04-08 13:46:33
Message-ID: 3e3d3427-3aca-3f3f-9dd9-ba575733c42e@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 1/13/17 6:55 AM, Marko Tiikkaja wrote:
>> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com
>> <mailto:Jim(dot)Nasby(at)bluetreble(dot)com>> wrote:
>>
>> On 1/11/17 5:54 AM, Pavel Stehule wrote:
>>
>> + <term><varname>too_many_rows</varname></term>
>> + <listitem>
>> + <para>
>> + When result is assigned to a variable by
>> <literal>INTO</literal> clause,
>> + checks if query returns more than one row. In this case
>> the assignment
>> + is not deterministic usually - and it can be signal some
>> issues in design.
>>
>>
>> Shouldn't this also apply to
>>
>> var := blah FROM some_table WHERE ...;
>>
>> ?
>>
>> AIUI that's one of the beefs the plpgsql2 project has.
>>
>>
>> No, not at all. That syntax is undocumented and only works because
>> PL/PgSQL is a hack internally. We don't use it, and frankly I don't
>> think anyone should.

This submission has been moved to CF 2017-07.

--
-David
david(at)pgmasters(dot)net

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2017-04-08 13:48:16 Re: Making clausesel.c Smarter
Previous Message Thomas Munro 2017-04-08 13:11:08 Re: recent deadlock regression test failures