From: | David Steele <david(at)pgmasters(dot)net> |
---|---|
To: | Marko Tiikkaja <marko(at)joh(dot)to>, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com> |
Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: plpgsql - additional extra checks |
Date: | 2017-03-16 15:04:30 |
Message-ID: | 32526c99-21bb-7073-44d1-31be2aba43bb@pgmasters.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 1/13/17 6:55 AM, Marko Tiikkaja wrote:
> On Fri, Jan 13, 2017 at 2:46 AM, Jim Nasby <Jim(dot)Nasby(at)bluetreble(dot)com
> <mailto:Jim(dot)Nasby(at)bluetreble(dot)com>> wrote:
>
> On 1/11/17 5:54 AM, Pavel Stehule wrote:
>
> + <term><varname>too_many_rows</varname></term>
> + <listitem>
> + <para>
> + When result is assigned to a variable by
> <literal>INTO</literal> clause,
> + checks if query returns more than one row. In this case
> the assignment
> + is not deterministic usually - and it can be signal some
> issues in design.
>
>
> Shouldn't this also apply to
>
> var := blah FROM some_table WHERE ...;
>
> ?
>
> AIUI that's one of the beefs the plpgsql2 project has.
>
>
> No, not at all. That syntax is undocumented and only works because
> PL/PgSQL is a hack internally. We don't use it, and frankly I don't
> think anyone should.
This patch still applies cleanly and compiles at cccbdde.
--
-David
david(at)pgmasters(dot)net
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2017-03-16 15:05:19 | Re: Partition-wise join for join between (declaratively) partitioned tables |
Previous Message | David Steele | 2017-03-16 14:59:25 | Re: [PATCH] guc-ify the formerly hard-coded MAX_SEND_SIZE to max_wal_send |