Re: Don't try fetching future segment of a TLI.

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: David Steele <david(at)pgmasters(dot)net>, Pavel Suderevsky <psuderevsky(at)gmail(dot)com>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, pgsql-bugs(at)lists(dot)postgresql(dot)org
Subject: Re: Don't try fetching future segment of a TLI.
Date: 2020-04-07 03:15:00
Message-ID: 3e0713d2-56d2-9883-4213-d5ba7f0dcabf@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 2020/04/07 4:04, David Steele wrote:
> On 4/6/20 1:43 PM, Fujii Masao wrote:
>>
>>
>> On 2020/03/19 22:22, Pavel Suderevsky wrote:
>>> Hi,
>>>
>>> I've tested patch provided by Kyotaro and do confirm it fixes the issue.
>>
>> The patch looks good to me. Attached is the updated version of the patch.
>> I updated only comments.
>>
>> Barring any objection, I will commit this patch.
>
> The patch looks good to me.
>
>>> Any chance it will be merged to one of the next minor releases?
>>
>> This doesn't seem a bug, so I'm thinking to merge this to next *major*
>> version release, i.e., v13.
>
> Not a bug, perhaps, but I think we do consider back-patching performance problems. The rise in S3 usage has just exposed how poorly this performed code in high-latency environments.

I understood the situation and am fine to back-patch that. But I'm not sure
if it's fair to do that. Maybe we need to hear more opinions about this?
OTOH, feature freeze for v13 is today, so what about committing the patch
in v13 at first, and then doing the back-patch after hearing opinions and
receiving many +1?

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Fujii Masao 2020-04-07 03:22:20 Re: Don't try fetching future segment of a TLI.
Previous Message Kyotaro Horiguchi 2020-04-07 01:29:09 Re: Don't try fetching future segment of a TLI.

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Langote 2020-04-07 03:17:07 Re: d25ea01275 and partitionwise join
Previous Message Tomas Vondra 2020-04-07 03:09:15 Re: [PATCH] Incremental sort (was: PoC: Partial sort)