From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | James Coleman <jtc331(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Rafia Sabih <rafia(dot)pghackers(at)gmail(dot)com>, Peter Geoghegan <pg(at)bowt(dot)ie>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Shaun Thomas <shaun(dot)thomas(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Andreas Karlsson <andreas(at)proxel(dot)se> |
Subject: | Re: [PATCH] Incremental sort (was: PoC: Partial sort) |
Date: | 2020-04-07 03:09:15 |
Message-ID: | 20200407030915.pfhncuknhrn3wxg4@development |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Mon, Apr 06, 2020 at 11:00:37PM -0400, Tom Lane wrote:
>Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
>> I came to the same conclusion (that the change in TuplesortMethod
>> definiton is the culprit) a while ago and was about to push a fix that
>> initialized it correctly in ExecSortInitializeDSM. But I agree reverting
>> it back to the old definition is probably better.
>
>Yeah, for the moment. James would like to not have
>SORT_TYPE_STILL_IN_PROGRESS be part of the enum at all, I think,
>and I can see his point --- but then we need some out-of-band
>representation of "worker not done", so I'm not sure there'll be
>any net reduction of cruft. Anyway that can be dealt with after
>we have a stable buildfarm.
>
Agreed.
>Note also that there's a separate comment-only patch in
><CAAaqYe9qzKbxCvSp3dfLkuS1v8KKnB7kW3z-hZ2jnAQaveSm8w(at)mail(dot)gmail(dot)com>
>that shouldn't be forgotten about.
>
OK, I'll take care of that tomorrow. I have two smaller patches to
commit in the incremental sort patchset, so I'll add it to that.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-04-07 03:15:00 | Re: Don't try fetching future segment of a TLI. |
Previous Message | Kyotaro Horiguchi | 2020-04-07 03:09:05 | Re: [HACKERS] Restricting maximum keep segments by repslots |