Re: TAP tests aren't using the magic words for Windows file access

From: Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: TAP tests aren't using the magic words for Windows file access
Date: 2019-11-07 14:41:43
Message-ID: 3d83a831-197b-e904-5bbb-3cce41c2f47d@2ndQuadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 11/7/19 9:12 AM, Alvaro Herrera wrote:
>>
>> The patch says:
>>
>> +        require Win32::API;
>> +        Win32::API->import;
> Oh, you're right, it does. I wonder why, though:
>

On further inspection I think those lines are unnecessary. The remainder
of the patch doesn't use this at all, AFAICT.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Sharma 2019-11-07 14:45:37 Re: tableam vs. TOAST
Previous Message Andrew Dunstan 2019-11-07 14:29:57 Re: TAP tests aren't using the magic words for Windows file access