Re: TAP tests aren't using the magic words for Windows file access

On 11/7/19 9:12 AM, Alvaro Herrera wrote:
> On 2019-Nov-07, Andrew Dunstan wrote:
>
>> On 11/7/19 8:53 AM, Alvaro Herrera wrote:
>>> That's a curious test to try, given that the module is called
>>> Win32API::File.
>> The patch says:
>>
>> +        require Win32::API;
>> +        Win32::API->import;
> Oh, you're right, it does. I wonder why, though:
>
> $ corelist -a Win32::API
>
> Data for 2018-11-29
> Win32::API was not in CORE (or so I think)
>
> $ corelist -a Win32API::File
>
> Data for 2018-11-29
> Win32API::File was first released with perl v5.8.9
> v5.8.9 0.1001_01
> v5.9.4 0.1001
> v5.9.5 0.1001_01
> v5.10.0 0.1001_01
> ...

Yes, that's present on jacana and fairywren (not on frogmouth, which is
running a very old perl, but it doesn't run TAP tests anyway.)

>
> According to the Win32API::File manual, you can request a file to be
> shared by passing the string "r" to svShare to method createFile().
> So do we really need all those extremely ugly "droppings" Juanjo added
> to the patch?
>
> (BTW the Win32API::File manual also says this:
> "The default for $svShare is "rw" which provides the same sharing as
> using regular perl open()."
> I wonder why "the regular perl open()" is not doing the sharing thing
> correctly ... has the problem has been misdiagnosed?).
>

Maybe we need "rwd"?

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services