From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: trailing junk in numeric literals |
Date: | 2020-12-29 09:18:27 |
Message-ID: | 3b6a5923-2e33-b5e1-2cec-b09f90b7d669@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2020-12-28 21:54, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>> I was surprised to find that this doesn't error:
>> => select 100a;
>> a
>> -----
>> 100
>
>> I suspect this and similar cases used to error before aliases without AS
>> were introduced. But now this seems possibly problematic. Should we
>> try to handle this better?
>
> Meh. I think you'd get more brickbats than kudos if you start insisting
> on a space there.
>
> I'm too lazy to try to decipher the SQL spec right now, but ISTR that
> it insists on whitespace between a numeric literal and an identifier.
Yeah, non-delimiter tokens are supposed to be separated by delimiter tokens.
> So strictly speaking this SQL code is nonstandard anyway. But our
> lexer has always been forgiving about not requiring space if it's
> not logically necessary to separate tokens. I doubt trying to
> change that would improve matters.
Well, the idea is to diagnose potential typos better. But if there is
no interest, then that's fine.
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-12-29 09:22:43 | Re: doc review for v14 |
Previous Message | Daniel Gustafsson | 2020-12-29 09:18:11 | Re: OpenSSL connection setup debug callback issue |