Re: Possible regression setting GUCs on \connect

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Nathan Bossart <nathandbossart(at)gmail(dot)com>, David Steele <david(at)pgmasters(dot)net>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Possible regression setting GUCs on \connect
Date: 2023-05-17 19:23:13
Message-ID: 3add6b53-7fea-9d2d-1c7b-5ca5dd94762f@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 5/17/23 1:30 PM, Alexander Korotkov wrote:
> Tom,
>
> On Wed, May 17, 2023 at 3:08 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
>>> Tom/Nathan, do you have any further suggestions here?
>>
>> My recommendation is to revert this feature. I do not see any
>> way that we won't regret it as a poor design.
>
> I have carefully noted your concerns regarding the USER SET patch that
> I've committed. It's clear that you have strong convictions about
> this, particularly in relation to your plan of storing the setter role
> OID in pg_db_role_setting.
>
> I want to take a moment to acknowledge the significance of your
> perspective and I respect that you have a different view on this
> matter. Although I have not yet had the opportunity to see the
> feasibility of your approach, I am open to understanding it further.
>
> Anyway, I don't want to do anything counter-productive. So, I've
> taken the decision to revert the USER SET patch for the time being.

Thanks Alexander. I know reverting a feature is not easy and appreciate
you taking the time to work through this discussion.

> I'm looking forward to continuing working with you on this subject for v17.

+1; I think everyone agrees there is a feature here that will be helpful
to our users.

Thanks,

Jonathan

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2023-05-17 19:34:48 Re: walsender performance regression due to logical decoding on standby changes
Previous Message Jonathan S. Katz 2023-05-17 19:21:25 Re: pg_stat_io not tracking smgrwriteback() is confusing