Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h

Hi Michael, Tom,

We use gcc-4.9.1, but it is ecpg pre-compiler that throws the error.
I'm not familiar with pg_indent.

Cheers,
Vlad

-----Original Message-----
From: Michael Meskes [mailto:meskes(at)postgresql(dot)org]
Sent: Monday, 1 February 2016 9:48 PM
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Meskes <meskes(at)postgresql(dot)org>; Vladimir Zvagolskiy <Vladimir(dot)Zvagolskiy(at)nasdaq(dot)com>; pgsql-bugs(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h

On Mon, Feb 01, 2016 at 10:56:44AM +0100, Tom Lane wrote:
> It seems a bit fishy that the comment in question starts on an #if
> line and ends on an ordinary line. I am not sure what the C standard
> says about such cases, but I can certainly imagine that some tools
> might not be very happy with that.

Very good catch. Vladimir, which compiler are you using?

> It looks like that code was last touched by pgindent in d747140279426607:

Let me guess, pg_indent?

It sure looks like it.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

***********************************************************
CONFIDENTIALITY NOTICE: This e-mail and any attachments are for the exclusive and confidential use of the intended recipient and may constitute non-public information. If you received this e-mail in error, disclosing, copying, distributing or taking any action in reliance of this e-mail is strictly prohibited and may be unlawful. Instead, please notify us immediately by return e-mail and promptly delete this message and its attachments from your computer system. We do not waive any work product or other applicable legal privilege(s) by the transmission of this message.
***********************************************************