| From: | Michael Meskes <meskes(at)postgresql(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Meskes <meskes(at)postgresql(dot)org>, Vladimir Zvagolskiy <Vladimir(dot)Zvagolskiy(at)nasdaq(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org> |
| Subject: | Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h |
| Date: | 2016-02-01 12:10:30 |
| Message-ID: | 20160201121030.GA18459@feivel |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Mon, Feb 01, 2016 at 10:56:44AM +0100, Tom Lane wrote:
> It seems a bit fishy that the comment in question starts on an #if line
> and ends on an ordinary line. I am not sure what the C standard says
> about such cases, but I can certainly imagine that some tools might not
> be very happy with that.
It turns out ecpg is one of these tools. Lines starting with #<whatever> are
considered CPP code and not parsed for C language comments. In the C code it
then finds only the end of the comment and throws the error.
It does surprise me, though, that the error only pops up now. I was pretty sure
at least one of these headers was used in the regression suit.
Will fix.
Thanks.
Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Meskes | 2016-02-01 12:16:20 | Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h |
| Previous Message | Vladimir Zvagolskiy | 2016-02-01 11:19:58 | Re: BUG #13898: ecpg complains on nested comments in /usr/pgsql-9.4/include/informix/esql/datetime.h |