| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some dblink refactoring |
| Date: | 2017-03-10 15:02:34 |
| Message-ID: | 3a26da6f-8083-4cff-ac8f-87b6c57853ff@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/8/17 00:10, Tsunakawa, Takayuki wrote:
> I changed the status to ready for committer. The patch applied cleanly, passed the regression test (make installcheck in contrib/dblink/), and the code looks perfect.
>
> How about applying the attached small patch for another refactoring? This merely changes makeStringInfo() to initStringInfo() at two sites just other places in the same file. makeStringInfo() on the function local variables leaves memory for StringInfoData allocated unnecessarily (which may be automatically reclaimed some time after.)
Committed both. Thanks.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Artur Zakirov | 2017-03-10 15:03:28 | Re: Should buffer of initialization fork have a BM_PERMANENT flag |
| Previous Message | Pavel Stehule | 2017-03-10 15:01:13 | Re: Re: proposal - psql: possibility to specify sort for describe commands, when size is printed |