| From: | "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com> |
|---|---|
| To: | 'Peter Eisentraut' <peter(dot)eisentraut(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: some dblink refactoring |
| Date: | 2017-03-08 05:10:56 |
| Message-ID: | 0A3221C70F24FB45833433255569204D1F6ADE94@G01JPEXMBYT05 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
From: pgsql-hackers-owner(at)postgresql(dot)org
> [mailto:pgsql-hackers-owner(at)postgresql(dot)org] On Behalf Of Peter Eisentraut
> Here is a patch to refactor some macro hell in dblink.
>
> This patch was discussed in the background sessions thread as a prerequisite
> for some work there, but I figure I'll make a separate thread for it to
> give everyone interested in dblink a chance to respond separate from the
> other thread.
I changed the status to ready for committer. The patch applied cleanly, passed the regression test (make installcheck in contrib/dblink/), and the code looks perfect.
How about applying the attached small patch for another refactoring? This merely changes makeStringInfo() to initStringInfo() at two sites just other places in the same file. makeStringInfo() on the function local variables leaves memory for StringInfoData allocated unnecessarily (which may be automatically reclaimed some time after.)
Regards
Takayuki Tsunakawa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tsunakawa, Takayuki | 2017-03-08 05:17:41 | Re: some dblink refactoring |
| Previous Message | Michael Paquier | 2017-03-08 04:35:10 | Re: CREATE/ALTER ROLE PASSWORD ('value' USING 'method') |